Skip to content

Conversation

@filzrev
Copy link
Contributor

@filzrev filzrev commented Oct 10, 2025

This PR add docs about breaking change that introduced by PR #2737.

After PR #2737 is merged.
It need to explicitly specify following settings to preserve old behaviors.

<BenchmarkDotNetTargetPlatform>all</BenchmarkDotNetTargetPlatform>

@timcassell
Copy link
Collaborator

I would move it to under Requirements where it already specifies csproj properties.

Copy link
Collaborator

@timcassell timcassell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@filzrev Can you address the comments?

@filzrev
Copy link
Contributor Author

filzrev commented Oct 31, 2025

I've update following changes

  • Apply Suggested change
  • Move Note content under Requirements section

Copy link
Collaborator

@timcassell timcassell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@timcassell timcassell merged commit 4a3b19c into dotnet:master Oct 31, 2025
8 checks passed
@timcassell timcassell added this to the v0.15.6 milestone Oct 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants